[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Tracebacks in svnadmin tests (fs->uuid issues)

From: Daniel Shahaf <danielsh_at_apache.org>
Date: Sat, 28 Apr 2012 11:27:37 +0300

AFAIK all of those are due to the same issue: dst_fs->uuid not being
initialized. Philip noted that there are probably worse problems here,
since fs_fs_shared_data_t (ffd->ffsd) holds various locks and caches tat
are indexed by UUID only.

This is at the top of my 'svn' todo list. (but that list is mostly
swapped out right now)

Thanks

Daniel

Greg Stein wrote on Fri, Apr 27, 2012 at 23:45:12 -0400:
> Hey Daniel,
>
> I had four svnadmin tests dump core due to an assertion: 8, 21, 26,
> 27. These are all marked XFail(), so my test run "passed".
>
> The stack traces on all four look like this:
>
> #4 0x000f4549 in svn_error__malfunction (can_return=1, file=0xa91bd
> "subversion/libsvn_fs_fs/fs.c", line=76, expr=0xa91b4 "fs->uuid") at
> subversion/libsvn_subr/error.c:698
> #5 0x00081455 in fs_serialized_init (fs=0x817f58,
> common_pool=0x80fa18, pool=0x80fa18) at
> subversion/libsvn_fs_fs/fs.c:76
> #6 0x00082040 in fs_hotcopy (src_fs=0x817f30, dst_fs=0x817f58,
> src_path=0x810028
> "/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/repositories/svnadmin_tests-8/db",
> dst_path=0x816a60
> "/Volumes/untitled/svn-test-work/repositories/svnadmin_tests-8.backup/db",
> clean_logs=0, incremental=0, cancel_func=0x240f <check_cancel>,
> cancel_baton=0x0, pool=0x80fa18) at subversion/libsvn_fs_fs/fs.c:321
> #7 0x00014337 in svn_fs_hotcopy2 (src_path=0x810028
> "/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/repositories/svnadmin_tests-8/db",
> dst_path=0x816a60
> "/Volumes/untitled/svn-test-work/repositories/svnadmin_tests-8.backup/db",
> clean=0, incremental=0, cancel_func=0x240f <check_cancel>,
> cancel_baton=0x0, scratch_pool=0x80fa18) at
> subversion/libsvn_fs/fs-loader.c:497
> #8 0x0005f8dd in svn_repos_hotcopy2 (src_path=0x80fc48
> "/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/repositories/svnadmin_tests-8",
> dst_path=0x80fce8 "", clean_logs=0, incremental=0, cancel_func=0x240f
> <check_cancel>, cancel_baton=0x0, pool=0x80fa18) at
> subversion/libsvn_repos/repos.c:1894
> #9 0x000052d7 in subcommand_hotcopy (os=0x80fb38, baton=0xbfffea7c,
> pool=0x80fa18) at subversion/svnadmin/main.c:1455
> #10 0x000075bf in main (argc=4, argv=0xbfffeb74) at
> subversion/svnadmin/main.c:2101
>
>
> The function calls are the same across the four. I have not examined
> them for line number or argument similarity, but just assumed all four
> had the same pattern.
>
> Cheers,
> -g
Received on 2012-04-28 10:27:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.