[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1330125 - /subversion/trunk/subversion/libsvn_ra_local/ra_plugin.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Wed, 25 Apr 2012 16:42:01 +0300

gstein_at_apache.org wrote on Wed, Apr 25, 2012 at 06:08:00 -0000:
> Author: gstein
> Date: Wed Apr 25 06:07:59 2012
> New Revision: 1330125
>
> URL: http://svn.apache.org/viewvc?rev=1330125&view=rev
> Log:
> Interpose the deltify_etc() commit callback in the RA_LOCAL commit
> process. This will unlock tokens and/or deltify the new revision.
>
> This change also renames a number of variables to current conventions.
>

Please separate commits for separate logical changes, or for functional
v. non-functional changes. They accumulate and they make reviewing harder.

Thanks.

> * subversion/libsvn_ra_local/ra_plugin.c:
> (struct deltify_etc_baton): rename a few members. remove POOL.
> (deltify_etc): rename param to SCRATCH_POOL and use it rather than
> DEB->POOL. rename DB to DEB. tighten scope of a couple vars. use
> hash_index funcs. rename a few localvars.
> (svn_ra_local__get_commit_editor): rename DB to DEB. track baton
> member renames
> (svn_ra_local__get_commit_ev2): prepare a deltify_etc_baton and
> interpose the deltify_etc commit callback. remove question about
> ra_svn (it does unlock/deltify post-drive rather than in the
> commit callback)
Received on 2012-04-25 15:42:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.