[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1330135 - /subversion/trunk/subversion/tests/svn_test.h

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 25 Apr 2012 04:37:27 -0400

On Wed, Apr 25, 2012 at 03:29, <julianfoad_at_apache.org> wrote:
> Author: julianfoad
> Date: Wed Apr 25 07:29:07 2012
> New Revision: 1330135
>
> URL: http://svn.apache.org/viewvc?rev=1330135&view=rev
> Log:
> * subversion/tests/svn_test.h
>  (SVN_TEST_STRING_ASSERT): Clarify the doc string, following r1329808.
>
> Modified:
>    subversion/trunk/subversion/tests/svn_test.h
>
> Modified: subversion/trunk/subversion/tests/svn_test.h
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test.h?rev=1330135&r1=1330134&r2=1330135&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/svn_test.h (original)
> +++ subversion/trunk/subversion/tests/svn_test.h Wed Apr 25 07:29:07 2012
> @@ -74,7 +74,9 @@ extern "C" {
>   } while (0)
>
>  /** Handy macro for testing string equality.
> - * EXPR and/or EXPECTED_EXPR may be NULL.
> + *
> + * EXPR and/or EXPECTED_EXPR may be NULL which compares equal to NULL and
> + * not equal to any non-NULL string.

Honestly, I don't care how it compares to anything. What does it do to
the *TEST*?

Does it raise a failure? Is it successful?

The docstring is opaque. I need to look at the macro to determine what
it will do to my test case.

Cheers,
-g
Received on 2012-04-25 10:38:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.