[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1327979 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_fs/fs-loader.c libsvn_repos/fs-wrap.c mod_dav_svn/repos.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 19 Apr 2012 17:21:16 +0100

Philip Martin <philip.martin_at_wandisco.com> writes:

> I moved that code without considering that. The documentation
> explicitly states that the result is allocated in pool but I think we
> can change that. It also allows me to rename pool to scratch_pool. I
> suppose there is a theoretical problem if libsvn_fs is dynamically
> loaded and the caller is passing a pool with a longer lifetime than the
> library. The constant string in the dynamic library would then have a
> shorter lifetime than it does now. Unlikely in practice I think.

Oops! The other bits of the function still allocate the result so pool
can't be scratch_pool.

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com
Received on 2012-04-19 18:21:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.