On Wed, Apr 18, 2012 at 18:42, Blair Zajac <blair_at_orcaware.com> wrote:
> On 04/18/2012 03:35 PM, Greg Stein wrote:
>> On Wed, Apr 18, 2012 at 18:11,<blair_at_apache.org> wrote:
>>> Author: blair
>>> Date: Wed Apr 18 22:11:43 2012
>>> New Revision: 1327703
>>> URL: http://svn.apache.org/viewvc?rev=1327703&view=rev
>>> Add and use svn_checksum__from_digest_sha1().
>>> This replaces svn_checksum__from_digest() taking a svn_checksum_sha1
>>> argument with a new svn_checksum_t constructor function.
>>> * subversion/include/private/svn_subr_private.h,
>>> * subversion/libsvn_subr/checksum.c
>>> New private function.
>>> * subversion/libsvn_fs_base/util/fs_skels.c
>>> svn_checksum__from_digest(digest, svn_checksum_sha1, pool);
>>> svn_checksum__from_digest_sha1(digest, pool);
>> Shouldn't we be using svn_checksum_serialize() and _deserialize()
>> rather than raw digests?
>> (iow, we "shouldn't" need from_digest_sha1)
> They don't contain the same bytes. I wasn't aware of
> svn_checksum_serialize() till now, but those prepend a checksum type string
> to the hex representation, as these are raw digest bytes.
> This work was to get rid of svn_checksum__from_digest(), which is now almost
> complete, per the other thread.
Yup, I understood. Sorry that I wasn't clear: I meant in our
serialization code, shouldn't we use the "proper" functions rather
than raw sha1 digests? Is there any way to switch to them at a
I haven't looked at that stuff, but I'm going to guess repositories
now exist with raw sha1 digests. Is there a format type in there? Can
we start writing "csum" and svn_checksum_serialize() into the skel?
And then read raw md5, raw sha1, or a serialized checksum?
Received on 2012-04-19 00:46:26 CEST