[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Changing svn_checksum__from_digest()'s signature

From: Blair Zajac <blair_at_orcaware.com>
Date: Tue, 17 Apr 2012 22:04:47 -0700

In case of an illegal svn_checksum_kind_t being passed to
svn_checksum__from_digest(), I want to change it from

svn_checksum_t *
svn_checksum__from_digest(const unsigned char *digest,
                           svn_checksum_kind_t kind,
                           apr_pool_t *result_pool);

to

svn_error_t *
svn_checksum__from_digest(svn_checksum_t **checksum,
                           const unsigned char *digest,
                           svn_checksum_kind_t kind,
                           apr_pool_t *result_pool);

This is to prevent a core dump we've observed with our RPC server.

The function is in a public .h file but shown as private. Do I need to
add svn_checksum__from_digest2() or can I just change it?

Blair
Received on 2012-04-18 07:05:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.