[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 16 Apr 2012 17:35:38 -0400

On Mon, Apr 16, 2012 at 13:50, <hwright_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_client/util.c Mon Apr 16 17:50:05 2012
>...
> +  /* ### We could probably calculate some of this once, and then cache it for
> +         use in this function. */
> +  SVN_ERR(svn_wc__get_wc_root(&wcroot_abspath, scb->wc_ctx,
> +                              scb->anchor_abspath,
> +                              scratch_pool, scratch_pool));
> +  SVN_ERR(svn_wc__node_get_url(&wcroot_url, scb->wc_ctx, wcroot_abspath,
> +                               scratch_pool, scratch_pool));
> +
> +  relpath = svn_uri_skip_ancestor(wcroot_url, node_url, scratch_pool);
> +  *local_abspath = svn_dirent_join(wcroot_abspath, relpath, result_pool);

Won't this join() fail in a switched working copy?
Received on 2012-04-16 23:36:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.