[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1311469 - in /subversion/trunk/subversion: include/svn_config.h libsvn_subr/config.c

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Tue, 10 Apr 2012 17:41:09 +0200

Philip Martin wrote:
> stefan2_at_apache.org writes:
>
>> svn_error_t *
>> +svn_config_get_int64(svn_config_t *cfg,
>> + apr_int64_t *valuep,
>> + const char *section,
>> + const char *option,
>> + apr_int64_t default_value)
>> +{
>> + const char *tmp_value;
>> + svn_config_get(cfg,&tmp_value, section, option, NULL);
>> + if (tmp_value)
>> + return svn_cstring_strtoui64(valuep, tmp_value,
>> + APR_INT64_MIN, APR_INT64_MAX, 10);
> svn_cstring_strtoi64?
>
> svn_config_get_uint46?
>
> ../src/subversion/libsvn_subr/config.c: In function ‘svn_config_get_int64’:
> ../src/subversion/libsvn_subr/config.c:711: warning: pointer targets in passing argument 1 of ‘svn_cstring_strtoui64’ differ in signedness
> ../src/subversion/include/svn_string.h:482: note: expected ‘apr_uint64_t *’ but argument is of type ‘apr_int64_t *’
>
A simple auto-completion artifact.
Fixed in r1311794.

Thanks for the review!
-- Stefan^2.
Received on 2012-04-11 01:58:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.