On 04/02/2012 07:52 PM, Greg Stein wrote:
> On Mon, Apr 2, 2012 at 10:57, <cmpilato_at_apache.org> wrote:
>> Author: cmpilato
>> Date: Mon Apr 2 14:57:14 2012
>> New Revision: 1308372
>>
>> URL: http://svn.apache.org/viewvc?rev=1308372&view=rev
>> Log:
>> Some cleanups and minor tweaks to the crypto code.
>>
>> * subversion/libsvn_subr/crypto.c
>> (crypto_init): Remove unnecessary #if-wrapping (APU_HAVE_CRYPTO).
>> While here, re-wrap (in a different sense of the word) some code.
>
> To be honest, one of my intended updates is to move *all* of the
> #ifdef stuff into crypto.c's functions. We've had problems where
> functions only appeared within certain build targets (notably under
> Windows). I think that the functions should always be available, but
> just return errors if the underlying library support is not present.
> Thus, callers never need to understand the vagaries of when something
> is/not available. Throw in an svn_crypto__is_available(), and it makes
> things even a bit easier.
>
> Any issues with that approach, that you can see?
It's not just the functions that have to deal with this. It's also the data
types. Of course, that's all the more reason why your introduction of
svn_crypto__ctx_t is a Good Thing -- we can #ifdef the
conditionally-available APR members (leaving an empty-but-defined structure,
if need be).
I'll see if I can't make this change now.
--
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on 2012-04-06 16:45:57 CEST