[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1309283 - in /subversion/trunk/subversion: include/private/svn_client_private.h libsvn_client/commit_util.c libsvn_client/copy.c libsvn_client/merge.c libsvn_client/mergeinfo.c libsvn_client/util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 4 Apr 2012 08:33:48 -0400

On Apr 4, 2012 4:26 AM, <julianfoad_at_apache.org> wrote:
>
> Author: julianfoad
> Date: Wed Apr 4 08:26:15 2012
> New Revision: 1309283
>
> URL: http://svn.apache.org/viewvc?rev=1309283&view=rev
> Log:
> Convert svn_client__wc_node_get_origin() to use svn_client__pathrev_t for
> its output.
>
> * subversion/include/private/svn_client_private.h,
> subversion/libsvn_client/util.c
> (svn_client__wc_node_get_origin): Use pathrev_t for the output.

This revision certainly shows how pathrev_t is a simplifying concept. Very
nice!

That said: I'd recommend being wary in your work about the struct being an
*input* param in public APIs. There are seriously heavy internal
constraints on the struct members. (eg. pass a struct with a NULL uuid, or
even a non-matching one)

I don't have a recommendation right now for what happens if the struct is
made public. I just wanted to raise a yellow flag. It seems best to keep it
very private because of the difficult constraints/preconditions in its
members.

Cheers,
-g
Received on 2012-04-04 14:34:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.