[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1305800 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 27 Mar 2012 12:32:41 -0400

On Tue, Mar 27, 2012 at 06:00, <stsp_at_apache.org> wrote:
> Author: stsp
> Date: Tue Mar 27 10:00:07 2012
> New Revision: 1305800
>
> URL: http://svn.apache.org/viewvc?rev=1305800&view=rev
> Log:
> * subversion/libsvn_wc/wc_db.c
>  (get_info_for_copy): Allow for NULL status parameter. Should have been
>    part of r1305793.

Woah! The way you implemented this won't work. Those if-branches need
to be taken, in order to fill out other OUT parameters.

Instead, you need a local status variable fetched from read_info().
Switch on that. And if STATUS is not NULL, then store the localvar
into the output.

>...

Cheers,
-g
Received on 2012-03-27 18:33:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.