Re: svn commit: r1303856 - in /subversion/trunk/subversion: bindings/swig/ruby/svn/fs.rb bindings/swig/ruby/test/test_info.rb svnlook/main.c tests/cmdline/svnlook_tests.py

On Thu, Mar 22, 2012 at 13:35, Philip Martin <philip.martin_at_wandisco.com> wrote:
> Greg Stein <gstein_at_gmail.com> writes:
>> On Mar 22, 2012 11:56 AM, <philip_at_apache.org> wrote:
>>>...
>>> This reverts r1302524 as the Ruby tests have been fixed in the same
>>> way.
>>
>> Edit svn:log on r1302524?
>
> OK.  I'm more interested in whether people think this is the right way
> to fix the problem.  Is asking for deltas during replay the right way to
> ensure that the node editor sets prop_mod?

From svn_repos_replay2():

 * If @a send_deltas is @c TRUE, the text and property deltas for changes
 * will be sent, otherwise NULL text deltas and empty prop changes will be
 * used.

That seems like it was abusing the delta editor right from the start.
I might suggest that we kill the parameter altogether.

If generating and delivering text deltas and property diffs is "too
much work", then I believe functionality which requires the
minimal-work use a new interface (not Ev1 or Ev2).

Cheers,
-g
Received on 2012-03-22 18:43:17 CET