[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1293998 - /subversion/trunk/subversion/libsvn_repos/replay.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 27 Feb 2012 10:19:35 +0000 (GMT)

Daniel Shahaf wrote:
>> danielsh_at_apache.org wrote:
>> > Fix issue #4121: svnsync of a copy followed by delete of
>> > was-unreadable child.
>> > http://subversion.tigris.org/issues/show_bug.cgi?id=4121
>> >
>> > * subversion/libsvn_repos/replay.c
>> >  (was_readable): New helper.
>> >  (path_driver_cb_func):
>> >    Use new helper to determine whether to replay or discard
>> > deletions.
>>
>> I've been trying to write a regression test for this, but got stuck
>> converting my shell script to Python.
>>
>> I have a shellscript (attached) that reproduces the issue for me: with
>> r1293997 it outputs
>>
>>     Copied properties for revision 1.
>>     subversion/libsvn_ra_svn/client.c:2440: (apr_err=210008)
>>     svnsync: E210008: Error while replaying commit
>>     zsh: exit 1    ./01repro
>>
>> I am also attaching an attempt at an equivalent Python test.  For me the
>> Python test passes against r1293997.  Can anyone spot the difference?

Your Python test fails against r1293997 and passes against r1293998 for me.  The fail against r1293997 looks like:

[...]
CMD: /home/julianfoad/src/subversion-c/bin/svnsync synchronize file:///nobackup/home/julianfoad/build/subversion-c/subversion/tests/cmdline/svn-test-work/repositories/copy-delete-unreadable-child-1 --username jrandom --password rayjandom --config-dir /nobackup/home/julianfoad/build/subversion-c/subversion/tests/cmdline/svn-test-work/local_tmp/config exited with 1
<TIME = 0.337972>
Transmitting file data .
Committed revision 1.
Copied properties for revision 1.
/home/julianfoad/src/subversion-c/subversion/svnsync/main.c:1384: (apr_err=160028)
/home/julianfoad/src/subversion-c/subversion/svnsync/main.c:1330: (apr_err=160028)
/home/julianfoad/src/subversion-c/subversion/libsvn_ra/ra_loader.c:1184: (apr_err=160028)
/home/julianfoad/src/subversion-c/subversion/libsvn_ra_neon/util.c:1324: (apr_err=160028)
/home/julianfoad/src/subversion-c/subversion/libsvn_ra_neon/util.c:1557: (apr_err=160028)
/home/julianfoad/src/subversion-c/subversion/libsvn_ra_neon/replay.c:181: (apr_err=160028)
/home/julianfoad/src/subversion-c/subversion/libsvn_repos/commit.c:136: (apr_err=160028)
/home/julianfoad/src/subversion-c/subversion/libsvn_repos/commit.c:136: (apr_err=160028)
svnsync: E160028: '/branch/A' is out of date
[...]

- Julian
Received on 2012-02-27 11:20:10 CET

This is an archived mail posted to the Subversion Dev mailing list.