[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

crash when committing

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 22 Feb 2012 22:18:00 +0100

Hi,

I'm going through some crash reports sent for TSVN and I found a crash
that happens when committing, and the wc has some incomplete entries:

libsvn_wc/node.c, svn_wc__internal_get_origin().

SVN_ERR(svn_wc__db_scan_addition(&status, &op_root_abspath, NULL,
                                 NULL, NULL, &original_repos_relpath,
                                 repos_root_url,
                                 repos_uuid, revision, NULL, NULL,
                                 db, local_abspath,
                                 result_pool, scratch_pool));

if (status == svn_wc__db_status_added)
  {
    if (is_copy)
      *is_copy = FALSE;
    return SVN_NO_ERROR; /* Local addition */
  }

*repos_relpath = svn_relpath_join(
                        original_repos_relpath,
                        svn_dirent_skip_ancestor(op_root_abspath,
                                                 local_abspath),
                        result_pool);

when the status is svn_wc__db_status_incomplete, the
original_repos_relpath can be NULL, and then the svn_relpath_join()
crashes because of a null-pointer access.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
Received on 2012-02-22 22:18:36 CET

This is an archived mail posted to the Subversion Dev mailing list.