[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1244593 - /subversion/trunk/subversion/libsvn_delta/compat.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 15 Feb 2012 12:30:09 -0500

On Feb 15, 2012 12:28 PM, "Hyrum K Wright" <hyrum.wright_at_wandisco.com>
wrote:
>
> On Wed, Feb 15, 2012 at 10:59 AM, <hwright_at_apache.org> wrote:
> > Author: hwright
> > Date: Wed Feb 15 16:59:56 2012
> > New Revision: 1244593
> >
> > URL: http://svn.apache.org/viewvc?rev=1244593&view=rev
> > Log:
> > Ev2 shims: What Greg hath broken, I shall fix.
> >
> > Followup to r1241748 by supplying the correct children in the shims to
> > svn_editor_add_directory().
> >
> > Current number of Ev2 test failures: 13
>
> Greg,
> Some of these failures are due to a bug in the completed children
> validation code in editor.c. The case that's interesting is when a
> directory is added, and one of its children is copied into place.
> That child is copied via svn_editor_copy(), which doesn't mark the
> child as completed, leaving incomplete children which trips the
> validator in svn_editor_close().
>
> I'm not completely decided on the right way to clean this up, but
> since you (re)wrote the validation code, I figured you'd have an idea.
> :)

Sure, I'll take care of it, O Tall One.

Cheers,
-g
Received on 2012-02-15 18:30:42 CET

This is an archived mail posted to the Subversion Dev mailing list.