[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1242958 - /subversion/trunk/subversion/libsvn_repos/log.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 10 Feb 2012 17:28:16 -0500

On 02/10/2012 05:24 PM, Bert Huijben wrote:
>
>
>> -----Original Message-----
>> From: hwright_at_apache.org [mailto:hwright_at_apache.org]
>> Sent: vrijdag 10 februari 2012 23:11
>> To: commits_at_subversion.apache.org
>> Subject: svn commit: r1242958 -
>> /subversion/trunk/subversion/libsvn_repos/log.c
>>
>> Author: hwright
>> Date: Fri Feb 10 22:10:34 2012
>> New Revision: 1242958
>>
>> URL: http://svn.apache.org/viewvc?rev=1242958&view=rev
>> Log:
>> Older (pre-1.6) revision files don't contain the information to fully populate
>> the changed_path hash for 'log -v' and 'log --xml'. If we encounter such a
>> condition, fetch the kind manually.
>
> Why do we add this now?
>
> We started sending the information 'when available' with 1.6, and I think we didn't retrieve the data for performance reasons. Did something change?
>
> This might be quite a performance regression for 'svnadmin upgrade'-d servers that were from <=1.5 before the last dump-load and it won't make the information magically available on clients, because there is no requirement to upgrade the server.
>
> Bert
>

I confess I was wondering the same thing. We really don't want any
additional performance penalties in the log code, which already suffers
severely when non-trivial authz rules are in place.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2012-02-10 23:28:51 CET

This is an archived mail posted to the Subversion Dev mailing list.