[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1241733 - /subversion/trunk/subversion/libsvn_delta/compat.c

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Wed, 8 Feb 2012 11:07:38 -0600

On Tue, Feb 7, 2012 at 10:55 PM, Greg Stein <gstein_at_gmail.com> wrote:
> That log message doesn't describe the change. You were already computing and
> passing a checksum.
>
> Maybe the bug was that you did not close TARGET to finalize the checksum
> computation?

I think that makes sense. Looking at other receivers of
apply_textdelta, it appears they had either manually close the source
stream, but not the target stream. I added something similar to the
shims in r1241976.

However, when I tried closing the target stream after the textdelta
was applied, I got an error that the file didn't exist. My guess is
that txdelta_apply() is closing the target stream (though I couldn't
find documentation to that effect). Why the checksum isn't getting
finalized is anybody's guess.

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-02-08 18:08:12 CET

This is an archived mail posted to the Subversion Dev mailing list.