[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

From: Matthijs Kooijman <matthijs_at_stdin.nl>
Date: Tue, 7 Feb 2012 23:15:18 +0100

Hi Daniel,

> > Index: subversion-trunk/subversion/bindings/swig/python/tests/client.py
> > ===================================================================
> > --- subversion-trunk.orig/subversion/bindings/swig/python/tests/client.py 2012-02-07 20:13:48.666552472 +0100
> > +++ subversion-trunk/subversion/bindings/swig/python/tests/client.py 2012-02-07 20:35:39.329660618 +0100
> > @@ -378,6 +378,7 @@
> > providers = core.svn_auth_get_platform_specific_client_providers(None, None)
> > # Not much more we can test in this minimal environment.
> > self.assert_(isinstance(providers, list))
> > + self.assert_(all(map(lambda x: isinstance(x, core.svn_auth_provider_object_t), providers)))
>
> Tests fail with:
>
> core.svn_auth_set_gnome_keyring_unlock_prompt_func(self.client_ctx.auth_baton, prompt_func)
> AttributeError: 'module' object has no attribute 'svn_auth_set_gnome_keyring_unlock_prompt_func'
Note that this is actually the test from the commit Stefan did, that
adds the svn_auth_set_gnome_keyring_unlock_prompt_func function, not the
one from the patch you were testing.

> I think the patch in your mail to Stefan may fix that?
The commit from Stefan to fix the Windows compile actually broke this
testcase. I just sent two more patches to fix this again.

In any case, the patch shown above should work regardless of what Stefan
does, so you should be able to commit that one already.

Gr.

Matthijs

Received on 2012-02-07 23:15:52 CET

This is an archived mail posted to the Subversion Dev mailing list.