[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c

From: Konstantin Kolinko <knst.kolinko_at_gmail.com>
Date: Tue, 17 Jan 2012 05:59:44 +0400

2012/1/17 Hyrum K Wright <hyrum.wright_at_wandisco.com>:
> On Mon, Jan 16, 2012 at 10:37 AM,  <neels_at_apache.org> wrote:
>> Author: neels
>> Date: Mon Jan 16 16:37:17 2012
>> New Revision: 1232059
>>
>> URL: http://svn.apache.org/viewvc?rev=1232059&view=rev
>> Log:
>> Add mod_setlocale to contrib.
>>
>> * contrib/server-side/mod_setlocale/mod_setlocale.c,
>> * contrib/server-side/mod_setlocale/README:
>>    New files.
>>
>> Patch by: danielsh (mod_setlocale.c), me (README file)
>
> I am concerned about this (and followup) commits.
>
> For the last several years, my understanding is that contrib/ has been
> deprecated.  We don't ship it with the release tarballs.  We've even
> been asking folks to move stuff out, where possible.  The Subversion
> project should not be a "hoster of {last,first} resort" when it comes
> to Subversion-related code.
>
> While I don't doubt the utility or quality of this code, contrib/ is
> not the place for it to live.
>

How can a generic HTTPD module that affect the whole HTTPD live in
subversion's contrib?

Quoting from its README:
[[[
17 * What:
18 mod_setlocale is a minimalistic httpd module that sets the locale for *THE
19 ENTIRE* httpd process. This also sets the native encoding of mod_dav_svn
20 and in consequence eliminates all of above problems.
]]]

You are not calling it "mod_svn_setlocale" and that rings some bells for me.

Best regards,
Konstantin Kolinko
Received on 2012-01-17 03:10:12 CET

This is an archived mail posted to the Subversion Dev mailing list.