[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1232189 - /subversion/trunk/contrib/server-side/mod_setlocale/mod_setlocale.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 16 Jan 2012 23:06:22 +0100

> -----Original Message-----
> From: danielsh_at_apache.org [mailto:danielsh_at_apache.org]
> Sent: maandag 16 januari 2012 23:04
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1232189 - /subversion/trunk/contrib/server-
> side/mod_setlocale/mod_setlocale.c
>
> Author: danielsh
> Date: Mon Jan 16 22:03:41 2012
> New Revision: 1232189
>
> URL: http://svn.apache.org/viewvc?rev=1232189&view=rev
> Log:
> Remove a debugging scaffolding.
>
> * contrib/server-side/mod_setlocale/mod_setlocale.c
> (setlocale_create_server_config): Reduce the severity of a logged message
> to APLOG_DEBUG.
>
> Modified:
> subversion/trunk/contrib/server-side/mod_setlocale/mod_setlocale.c
>
> Modified: subversion/trunk/contrib/server-
> side/mod_setlocale/mod_setlocale.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/contrib/server-
> side/mod_setlocale/mod_setlocale.c?rev=1232189&r1=1232188&r2=1232189
> &view=diff
> ==========================================================
> ====================
> --- subversion/trunk/contrib/server-side/mod_setlocale/mod_setlocale.c
> (original)
> +++ subversion/trunk/contrib/server-side/mod_setlocale/mod_setlocale.c
> Mon Jan 16 22:03:41 2012
> @@ -115,7 +115,7 @@ static void *
> setlocale_create_server_config(apr_pool_t *p, server_rec *s)
> {
> setlocale_config_rec *cfg = apr_pcalloc(p, sizeof(*cfg));
> - ap_log_error(APLOG_MARK, APLOG_EMERG, 0, s,
> + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s,
> "create: 0x%08x", cfg);

Doesn't this assume a 32 bit machine?

Is %p for a pointer portable enough?

        Bert

> return cfg;
> }
>
Received on 2012-01-16 23:07:40 CET

This is an archived mail posted to the Subversion Dev mailing list.