On 19/12/11 10:04 +0200, Daniel Shahaf wrote:
>Please send separate patches for separate functional changes. Getting
>the tests to pass with ruby1.8 would be a separate functional change than
>supporting ruby1.9.
Okay after a bit of familiarizing myself with the svn library, attached
are two patches. One that is a patch to accomodate the ruby bindings for
1.8 and 1.9 (svn-ruby-1.9-fixes.patch).
The other is an update to the unit tests, to catch ruby 1.9
up to speed, while not breaking the tests for ruby 1.8 (svn-update-ruby-tests.patch)
All tests pass ruby 1.8, like they have, and all but 1 pass on ruby
1.9.3. The one test that is failing is in time_delta.rb, and is due to
the overhaul of encoding that happened for ruby 1.9. I would welcome
someone investigating this encoding challenge too. But otherwise things
look pretty good to support ruby 1.9 now.
Take care,
--
Vincent Batts
- application/pgp-signature attachment: stored
Received on 2011-12-21 06:09:16 CET