[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Choice of constant in libsvn_fs_base

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Fri, 25 Nov 2011 00:00:15 +0200

While reviewing r1205726 I came across this pearl:

reps-strings.c- /* Make a list of all the rep's we need to undeltify this range.
reps-strings.c- We'll have to read them within this trail anyway, so we might
reps-strings.c- as well do it once and up front. */
reps-strings.c- apr_array_header_t *reps = /* ### what constant here? */
reps-strings.c: apr_array_make(pool, 666, sizeof(rep));

Isn't that constant a little too large? Will any existing repository
ever need a chain of deltas that contains >600 elements? Can we set the
constant to 30?
Received on 2011-11-24 23:01:01 CET

This is an archived mail posted to the Subversion Dev mailing list.