Re: svn commit: r1203546 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

philip_at_apache.org writes:

> Author: philip
> Date: Fri Nov 18 09:09:56 2011
> New Revision: 1203546

> Also, a nested Location inside an SVNPath Location is ambiguous so
> prevent access and log the problem.

> + if (parent->fs_path)
> + {
> + /* Nesting inside SVNPath is ambiguous so prevent access. */
> + newconf->fs_path = newconf->fs_parent_path = NULL;
> +
> + ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
> + "mod_dav_svn: invalid nested Location '%s' inside "
> + "SVNPath Location '%s'",
> + child->root_dir, parent->root_dir);
> + }

I'm having second thoughts about this bit. Given

<Location /foo>
  ...
  SVNPath /some/foo
</Location>
<Location /foo/bar>
  ...
  SVNPath /some/bar
</Location>

there is obvious ambiguity about the URL /foo/bar. Is it the root of
the repository at /foo/bar or is it /bar in the repository at /foo?
However provided I'm not trying to use /bar inside the /foo repository
then checkouts, updates and commits work for both repositories. (Some
operations even work on /bar inside /foo, although not enough to be
useful.)

What that means is that some people may be using this setup, either
intentionally or accidentally. Should we continue to support them? If
we choose not to support them in 1.8 can we make the change in 1.7.2 as
well?

-- 
Philip