Re: svn commit: r1196005 - in /subversion/trunk/subversion/svn: cl.h copy-cmd.c util.c
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 1 Nov 2011 15:16:00 +0000 (GMT)
C. Michael Pilato wrote:
Now I've taken a look... no, actually it appears to have been an assumption made in issue #3416 "Cannot add or commit 'email@example.com'" and more specifically in issue #3651 "svn copy does not eat peg revision within copy target path". Those issues were resolved by making the target ignore ("eat") unwanted peg revisions, but what we should have done instead is reject any unexpected peg revision, which is what my patch does now.
A test run indicates there's only one such test, copy_tests.py 62.
Since these are relatively new issues (2009/2010) and the test for a target ending with "@HEAD" was only introduced then, I think we are safe to remove that special case.
Thanks for querying.
I'll remove the exception, and change the test for a destination path ending in '@HEAD' to one ending in '@' so that it still tests the ignoring of an empty peg revision specifier.
This is an archived mail posted to the Subversion Dev mailing list.