[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1181040 - svn_ra_check_path2() in branches/tree-read-api ...

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Mon, 10 Oct 2011 18:17:38 +0100

Bert Huijben wrote:
> > Author: julianfoad
> > On the 'tree-read-api' branch: Implement svn_ra_get_symlink() and make
> > svn_ra_check_path2() support symlinks.
> >
> > * subversion/include/svn_ra.h
> > (svn_ra_get_symlink): New function.
> >
> > * subversion/libsvn_ra/ra_loader.c
> > (svn_ra_get_symlink): New function.
> > (svn_ra_check_path2): Use svn_ra_get_symlink() to detect symlinks.
>
> If you intend to merge this code back to trunk eventually:
>
> I think it would be better if svn_ra_check_path2 uses a single
> new/updated call to get the right information. This change makes
> svn_ra_check_path2() twice as slow as svn_ra_check_path() for the very
> common case where the target is a file.

Yes, good point. This is however part of a symlink-support feature
which was not the purpose of this branch, so I'll raise it (symlink
support, that is) separately.

- Julian

> (And svn_ra_check_path is often just used to check if the path
> exists)
Received on 2011-10-10 19:18:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.