[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1175903 - in /subversion/trunk/subversion: include/svn_mergeinfo.h libsvn_client/merge.c libsvn_repos/log.c libsvn_subr/deprecated.c libsvn_subr/mergeinfo.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 28 Sep 2011 18:28:50 +0200

On Wed, Sep 28, 2011 at 06:16:18PM +0200, Stefan Sperling wrote:
> On Mon, Sep 26, 2011 at 03:15:21PM -0000, pburba_at_apache.org wrote:
> > Author: pburba
> > Date: Mon Sep 26 15:15:21 2011
> > New Revision: 1175903
> > URL: http://svn.apache.org/viewvc?rev=1175903&view=rev
> > Log:
> > Rev svn_mergeinfo_merge API to use the two-pool paradigm.
>
> > * subversion/libsvn_subr/mergeinfo.c
> >
> > (svn_mergeinfo_merge2): New.
>
> Hi Paul,
>
> I think this commit introduced a pool lifetime issue. See below.

Oh, nevermind. Looking closer at the implementation of svn_sort__hash(),
the key pointer in the temporary array has the same value as the key
pointer in the hash table. So this should be fine.
Received on 2011-09-28 18:29:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.