On Mon, Sep 19, 2011 at 11:05, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> On 09/19/2011 10:58 AM, gstein_at_apache.org wrote:
>> Author: gstein
>> Date: Mon Sep 19 14:58:47 2011
>> New Revision: 1172652
>>
>> URL: http://svn.apache.org/viewvc?rev=1172652&view=rev
>> Log:
>> Add a new "spill buffer" type and functions, extracted from ra_serf. This
>> type will buffer content in memory until it reaches a specified size,
>> where it will then spill additional content onto disk.
>
> Awesome. Wanna drop an exemplary use thereof into
> subversion/libsvn_repos/reporter.c (for use with the
> report_baton_t->tempfile member)? I've been wanting to make that change for
> some time now, and this would prove a good demonstration of your new logic.
I'm going to write a unit test for the code. That should provide a
good demonstration.
The code that I first checked in uses a callback to do the reading
(appropriate for the xml parsing in ra_serf), but I don't know if that
works for ra_neon. ie. the push vs pull problem. But that said, I've
just adjusted the code to *also* provide a pull option (rather than
push into a callback). Gonna commit that, and then work on the unit
test.
>...
Cheers,
-g
Received on 2011-09-20 13:19:34 CEST