[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Speed up client by re-using RA session connections

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 15 Sep 2011 01:03:34 +0400

On Wed, Sep 14, 2011 at 19:29, Daniel Shahaf <danielsh_at_elego.de> wrote:
>>   - Implement a private API for libsvn_client functions to use instead of
>>     simply opening a new session. It re-uses a session from the cache, if
>>     present, or opens a new connection if necessary.
>
> As far as I can see, the "get a session from the cache" code assumes
> that the cache is used by a single thread.  (Consider what happens if
> one thread retrieves or uses a cached session while another retrieves
> the same session from the cache.)  Will the cache be thread-safe?
>
We can create differnet RA session cache for each
svn_client_context_t instance, which is cannot be shared between
threads.

-- 
Ivan Zhakov
Received on 2011-09-14 23:04:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.