[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1165787 - in /subversion/trunk: build.conf subversion/include/svn_delta.h subversion/libsvn_delta/compat.c subversion/tests/libsvn_delta/ subversion/tests/libsvn_delta/editor-test.c

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Wed, 7 Sep 2011 19:49:54 -0500

On Wed, Sep 7, 2011 at 5:02 PM, Greg Stein <gstein_at_gmail.com> wrote:
> On Tue, Sep 6, 2011 at 15:06,  <hwright_at_apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/include/svn_delta.h Tue Sep  6 19:06:38 2011
>> @@ -42,6 +42,8 @@
>>  #include "svn_io.h"
>>  #include "svn_checksum.h"
>>
>> +#include "private/svn_editor.h"
>> +
>>  #ifdef __cplusplus
>>  extern "C" {
>>  #endif /* __cplusplus */
>> @@ -1085,6 +1087,22 @@ typedef struct svn_delta_editor_t
>>  svn_delta_editor_t *
>>  svn_delta_default_editor(apr_pool_t *pool);
>>
>> +/* Return a delta editor and baton which will forward calls to @a editor,
>> + * allocated in @a pool.
>> + *
>> + * @note: Since the semantics behind the two editors are different, calls
>> + * the timing of calls forwarded to @a editor may be imprecise.  That is,
>> + * the memory and computational overhead in using this forwarding
>> + * mechanism may be large.
>> + *
>> + * @since New in 1.8.
>> + */
>> +svn_error_t *
>> +svn_delta_from_editor(svn_delta_editor_t **deditor,
>> +                      void **dedit_baton,
>> +                      svn_editor_t *editor,
>> +                      apr_pool_t *pool);
>
> Constify DEDITOR, please.
>
>>...
>> +++ subversion/trunk/subversion/tests/libsvn_delta/editor-test.c Tue Sep  6 19:06:38 2011
>>...
>> +static svn_error_t *
>> +get_noop_editor(svn_editor_t **editor,
>> +                void *editor_baton,
>> +                svn_cancel_func_t cancel_func,
>> +                void *cancel_baton,
>> +                apr_pool_t *result_pool,
>> +                apr_pool_t *scratch_pool)
>> +{
>> +  svn_editor_cb_many_t editor_cbs = {
>
> static const.
>
>>...

All done in r1166481.

Thanks,
-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2011-09-08 02:50:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.