Re: diff copyfrom, and other inconsistencies [was: Re: diff --summarize]

On Tue, Aug 23, 2011 at 07:01:18PM +0200, Bert Huijben wrote:
> Note that one of the reasons we abandoned this approach here and in the
> update editor was that there was no way to know when the revision was
> copied.

What do you mean, abandoned it "here"?
AFAIK diff never used this.

> E.g. there might be 100 new file revisions at the new path, after the copy
> was performed and you would still get it reported as a copy via the editor
> callback. We just send the previous path for additions.

Why is this a problem for diff?
If the copy happened anywhere within the diffed revision range -rN:M,
I want to see the copy event. Even if there are subsequent edits on
the copy destination path within the same revision range.

> (The update editor approach also had different problems though)
>
> Making this more reliable requires editor changes or further requests to the
> repository to validate the result.

Which kind of reliability enhancements are you referring to?
Received on 2011-08-23 20:51:22 CEST