[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: JavaHL Bug: cannot propedit versioned props by URL

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Tue, 16 Aug 2011 15:35:21 -0500

r1158436 allows you to specify the base revision for the URL to
satisfy the underlying API requirements. I didn't commit the test.

(I assume that once the test and other fixes are in place, the whole
lot will be nominated for 1.7.x.)

-Hyrum

On Tue, Aug 16, 2011 at 2:28 PM, Mark Phippard <markphip_at_gmail.com> wrote:
> Attaching this time ...
>
> On Tue, Aug 16, 2011 at 3:26 PM, Mark Phippard <markphip_at_gmail.com> wrote:
>>
>> On Tue, Aug 16, 2011 at 3:09 PM, Hyrum K Wright
>> <hyrum.wright_at_wandisco.com> wrote:
>>>
>>> On Tue, Aug 16, 2011 at 11:59 AM, Mark Phippard <markphip_at_gmail.com>
>>> wrote:
>>> > The JavaHL propertySetRemote API seems incomplete.
>>> > 1) It does not take a CommitMessageCallback.  So no way to provide
>>> > commit
>>> > message.
>>>
>>>  r1158421 added the CommitMessageCallback to the propertSetRemote API.
>>>
>>> > 2) When trying to change a versioned property via URL, it fails with:
>>> > Bogus revision information given
>>> > svn: Setting property on non-local targets needs a base revision
>>> > We want to use this API in Subclipse to freeze svn:externals properties
>>> > in a
>>> > tag after committing it.  TortoiseSVN seems to offer to do this now.
>>>
>>> I'm not sure exactly what's going on here, or how to trigger it.  If
>>> possible, a test case would go a long way toward illuminating this.
>>
>> I have attached a patch that adds a new test that shows the problem. When
>> this is working I would probably enhance the test to update the WC and
>> verify the prop change.
>> When I run the test with current trunk it fails with this:
>> There was 1 error:
>> 1)
>> testPropEdit(org.apache.subversion.javahl.BasicTests)org.apache.subversion.javahl.ClientException:
>> Bogus revision information given
>> svn: Setting property on non-local targets needs a base revision
>> at native.subversion.libsvn_client(prop_commands.c:418)
>> at org.apache.subversion.javahl.SVNClient.propertySetRemote(Native Method)
>> at
>> org.apache.subversion.javahl.BasicTests.testPropEdit(BasicTests.java:3146)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> at org.apache.subversion.javahl.RunTests.main(RunTests.java:116)
>> FAILURES!!!
>> Tests run: 1,  Failures: 0,  Errors: 1
>>
>> --
>> Thanks
>>
>> Mark Phippard
>> http://markphip.blogspot.com/
>
>
>
> --
> Thanks
>
> Mark Phippard
> http://markphip.blogspot.com/
>

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2011-08-16 22:35:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.