[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1157682 - /subversion/trunk/subversion/svn/status.c

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Mon, 15 Aug 2011 07:18:18 -0500

Do we do this other places in our code, or does this introduce a new pattern?

It *does* introduce new "format not a string literal, argument types
not checked" warnings at compile-time.

-Hyrum

On Sun, Aug 14, 2011 at 6:06 PM, <arfrever_at_apache.org> wrote:
> Author: arfrever
> Date: Sun Aug 14 23:06:09 2011
> New Revision: 1157682
>
> URL: http://svn.apache.org/viewvc?rev=1157682&view=rev
> Log:
> Follow-up to r1157537:
>
> * subversion/svn/status.c
>  (print_status): Include %s in translated messages to support languages,
>   in which "from" / "to" are postpositions.
>
> Modified:
>    subversion/trunk/subversion/svn/status.c
>
> Modified: subversion/trunk/subversion/svn/status.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/status.c?rev=1157682&r1=1157681&r2=1157682&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svn/status.c (original)
> +++ subversion/trunk/subversion/svn/status.c Sun Aug 14 23:06:09 2011
> @@ -268,8 +268,11 @@ print_status(const char *path,
>       SVN_ERR(svn_dirent_get_absolute(&cwd, "", pool));
>       relpath = make_relpath(cwd, status->moved_from_abspath, pool, pool);
>       relpath = svn_dirent_local_style(relpath, pool);
> -      moved_from_line = apr_psprintf(pool, "\n        > %s %s",
> -                                     _("moved from"), relpath);
> +      moved_from_line = apr_psprintf(pool,
> +                                     apr_psprintf(pool,
> +                                                  "\n        > %s",
> +                                                  _("moved from %s")),
> +                                     relpath);
>     }
>
>   /* Only print an extra moved-to line for the op-root of a move-away.
> @@ -285,8 +288,11 @@ print_status(const char *path,
>       SVN_ERR(svn_dirent_get_absolute(&cwd, "", pool));
>       relpath = make_relpath(cwd, status->moved_to_abspath, pool, pool);
>       relpath = svn_dirent_local_style(relpath, pool);
> -      moved_to_line = apr_psprintf(pool, "\n        > %s %s",
> -                                   _("moved to"), relpath);
> +      moved_to_line = apr_psprintf(pool,
> +                                   apr_psprintf(pool,
> +                                                "\n        > %s",
> +                                                _("moved to %s")),
> +                                   relpath);
>     }
>
>   if (detailed)
>
>
>

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2011-08-15 14:18:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.