Mark Phippard wrote on Thu, Jun 30, 2011 at 14:36:40 -0400:
> On Thu, Jun 30, 2011 at 2:31 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>
> >> The reason SQLite was used is that rev props can be edited via svn
> >> prop*--revprop
> >>
> >> So you could also disable the pre-revprop-change hook during a backup
> >> and that should make you safe. And if you have not enabled it in the
> >> first place, then there is really no issue anyway.
> >>
> >
> > Inaccurate.
> >
> > The pre-revprop-change hook lives in libsvn_repos. It has zero effect
> > on API users that change revprop via libsvn_fs API's.
>
> OK, then what is accurate? Are you saying we do not support editing
> revision properties once they are packed? Is the SQLite db that
> stores revprops only written to by the pack process?
It is possible to edit revprops both before and after 'svnadmin pack'.
In the 'after' case, a non-svn_fs_pack() process modifies revprops.db
in-place.
My point was that svn_fs_change_rev_prop2() always works regardless of
any hooks configuration. Hooks only exist in the libsvn_repos layer;
they do not exist in the libsvn_fs (and lower) layers.
Received on 2011-06-30 20:42:40 CEST