[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1141133 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 29 Jun 2011 15:59:00 -0400

On Wed, Jun 29, 2011 at 15:03, Daniel Shahaf <danielsh_at_apache.org> wrote:
> Blair Zajac wrote on Wed, Jun 29, 2011 at 10:11:21 -0700:
>> On 06/29/2011 08:22 AM, danielsh_at_apache.org wrote:
>> >Author: danielsh
>> >Date: Wed Jun 29 15:22:38 2011
>> >New Revision: 1141133
>> >
>> >URL: http://svn.apache.org/viewvc?rev=1141133&view=rev
>> >Log:
>> >* subversion/libsvn_subr/sqlite.c
>> >   (svn_sqlite__open):
>> >     Only enable the workaround when we are compiled against SQLite 3.7.7.x
>> >     and earlier.  This should be safe since the version of SQLite at run-time
>> >     cannot be older than the version at compile-time.
>>
>> And this is true due to a startup check where svn checks the
>> compiled versus runtime version and fails to initialize sqlite?
>>
>
> Yes, according to Peter.
>
> I find this code in init_sqlite(), but I haven't checked that that
> function is called from all the places it needs to be called from:

To do anything interesting with SQLite, you must use
svn_sqlite__open(), and init_sqlite is called from there. I posit
there are no other "all the places" of any concern.

Cheers,
-g
Received on 2011-06-29 21:59:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.