[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1139806 - in /subversion/trunk: Makefile.in subversion/tests/cmdline/svnserveautocheck.sh

From: Peter Samuelson <peter_at_p12n.org>
Date: Mon, 27 Jun 2011 13:07:00 -0500

[danielsh_at_apache.org]
> * subversion/tests/cmdline/svnserveautocheck.sh
> (#!): s#/bin/bash#/bin/sh#
> ($PYTHON): Use this environment variable, if available.
> (): Replace bash-specific constructs with more portable equivalents.

Looks good:

    $ checkbashisms svnserveautocheck.sh
    possible bashism in svnserveautocheck.sh line 90 ($BASH_SOMETHING):
      if [ -n "$BASH_VERSION" ]; then
    possible bashism in svnserveautocheck.sh line 91 ($RANDOM):
        echo $(($RANDOM+1024))
    possible bashism in svnserveautocheck.sh line 114 (time):
      time make check "BASE_URL=$BASE_URL"
    possible bashism in svnserveautocheck.sh line 120 (time):
      time "./${TEST}_tests.py" "--url=$BASE_URL" $*

The first two are false positives. The last two ... I don't know why
checkbashisms thinks 'time' might be bash-specific.

-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
Received on 2011-06-27 20:07:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.