[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Follow-up to r1138830. Fix comment in test.

From: Noorul Islam K M <noorul_at_collab.net>
Date: Fri, 24 Jun 2011 11:44:59 +0530

Noorul Islam K M <noorul_at_collab.net> writes:

> Log
> [[[
>
> Follow-up to r1138830. Remove comment in test which became absolute
> after r1138830. Add new comment related to issue #3936.
>
> * subversion/tests/cmdline/log_tests.py
> (log_with_unrelated_peg_and_operative_revs): Fix absolute comment and
> add new relevant one.
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>

The log message had minor typo. Sending the correct one.

Log
[[[

Follow-up to r1138830. Remove comment in test which became obsolete
after r1138830. Add new comment related to issue #3936.

* subversion/tests/cmdline/log_tests.py
  (log_with_unrelated_peg_and_operative_revs): Fix obsolete comment and
    add new relevant one.

Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]

Thanks and Regards
Noorul

>
> Index: subversion/tests/cmdline/log_tests.py
> ===================================================================
> --- subversion/tests/cmdline/log_tests.py (revision 1139154)
> +++ subversion/tests/cmdline/log_tests.py (working copy)
> @@ -1983,6 +1983,10 @@
>
> target = sbox.repo_url + '/A/D/G/rho_at_2'
>
> + # Currently this test fails because ra_serf returns an SVN_ERR_FS_NOT_FOUND
> + # error from svn_ra_get_locations() that the other RA layers do not
> + # return. The test passes with all other RA layers. See issue #3936.
> +
> # log for /A/D/G/rho, deleted in revision 5, recreated in revision 8
> expected_error = ".*File not found.*"
> svntest.actions.run_and_verify_svn(None, None, expected_error,
> @@ -1996,10 +2000,6 @@
> svntest.actions.run_and_verify_svn(None, None, expected_error,
> 'log', '-r', '9:2', target)
>
> - # Currently this test fails because instead of returning the expected
> - # 'Unable to find repository location for ^/A/D/G/rho in revision 9'
> - # error, the log for ^/A/D/G/rho_at_8 is returned, but that is an unrelated
> - # line of history.
> expected_error = ".*Unable to find repository location for.*"
> svntest.actions.run_and_verify_svn(None, None, expected_error,
> 'log', '-r', '2:HEAD', target)
Received on 2011-06-24 08:17:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.