On Thu, Jun 23, 2011 at 2:47 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
>> -----Original Message-----
>> From: Greg Stein [mailto:gstein_at_gmail.com]
>> Sent: donderdag 23 juni 2011 21:01
>> To: dev_at_subversion.apache.org
>> Subject: Re: svn commit: r1132968 - in
>> /subversion/trunk/subversion/include: svn_types.h svn_version.h
>>
>> On Tue, Jun 7, 2011 at 08:14, <rhuijben_at_apache.org> wrote:
>> > Author: rhuijben
>> > Date: Tue Jun 7 12:14:14 2011
>> > New Revision: 1132968
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1132968&view=rev
>> > Log:
>> > Following up on r1132965, just move the type. This matches how we
>> handled the
>> > problem for svn_error_t.
>> >
>> > * subversion/include/svn_types.h
>> > (svn_version_t): Add full definition here.
>> >
>> > * subversion/include/svn_version.h
>> > (svn_version_t): And remove it here.
>>
>> I've been thinking more on this change and absolutely hate it.
>>
>> We have a header DEDICATED to this structure and its concepts. The
>> structure should be in that header file. It makes no sense to have a
>> dedicated header, yet to move its key structure somewhere else.
>>
>> Please revert this change.
>
> We also have a header file dedicated to svn_error_t and yet it is defined in
> svn_types.h.
>
> The fact that you personally hate it doesn't add any weight to your other
> arguments.
>
> I don't see any other strong opinions on this and as you try to teach
> everyone on this list Apache doesn't have per project dictators who say what
> can, can't and must be done. With a veto we ask for a different solution in
> order not to stall the project.
For the record: I'm with Greg (and others) on this. I moving the
struct out of it's "home" header file doesn't make any sense.
> What solution do you suggest for having a header included everywhere that
> changes on every tag?
How often do we create new tags? It's certainly less often then
somebody commits to svn_error.h or svn_error_codes.h (which are just
about universally included).
A better question would be: what problem are you trying to solve here?
Is it strictly one of build time?
-Hyrum
> Can we move the defines that change to a different header that isn't
> included everywhere?
> What kind of forward (typedef) would work to allow keeping the reduced set
> of includes?
>
> I just did what you did in early 1.7 development: reduce the number of
> recursive header includes and this one really helps in the build time:
> Especially for third party projects building on top of Subversion. (Which we
> currently ask to follow trunk)
>
> Bert
>
>
Received on 2011-06-23 21:54:02 CEST