[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

API review - svn_sorts ... svn_xml.h

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Mon, 13 Jun 2011 16:22:20 +0100

This is a list of all the changes to public symbols, with a few drive-by
remarks. Comparing 1.6.17 to trunk_at_1134000; I'll check for any
subsequent changes on trunk later.

HEADERS REVIEWED

  svn_sorts.h - no change
  svn_string.h
  svn_subst.h
  svn_time.h - no change
  svn_types.h
  svn_user.h - no change
  svn_utf.h - no change
  svn_version.h
  svn_wc.h
  svn_xml.h - no change

NEW AND CHANGED SYMBOLS

svn_string.h
  + svn_stringbuf_appendbyte()
  ! svn_cstring_match_glob_list() - gets 'const' on its array input
  + svn_cstring_match_list()
  + svn_cstring_strtoi64()
  + svn_cstring_atoi64()
  + svn_cstring_atoi()
  + svn_cstring_strtoui64()
  + svn_cstring_atoui64()
  + svn_cstring_atoui()
    # These numeric conversion funcs should define the valid input format.

svn_subst.h
  + svn_subst_copy_and_translate4() - supports cancellation
  + svn_subst_translate_string2() - can repair EOL; says if translated
  - svn_subst_translate_string() - deprecated
    # Doesn't mention the inability to control repair of EOL.

svn_types.h
  + SVN_UNALIGNED_ACCESS_IS_OK
  + svn_version_t - moved to here from svn_version.h
  ! svn_node_kind_t - gets an enum tag name to match typedef
  + svn_tristate_t
  + svn_tristate_to_word()
    # Are the strings localized or fixed? Make private?
  + svn_tristate_from_word()
    # Are the strings localized or fixed? Make private?
  ! svn_depth_t - gets an enum tag name to match typedef
  ! svn_commit_info_t - gets a 'repos_root' field
    # Should be named 'repos_root_url'?
    # Should also get a 'repos_uuid' field?
  ! svn_log_changed_path2_t - gets 'text_modified' and 'props_modified' fields
    # Do these new fields make sense in general logs?
  ! svn_log_entry_t - gets 'non_inheritable' and 'subtractive_merge' fields
  ! svn_log_entry_dup() - gets 'const' on its input
  ! svn_merge_range_dup() - gets 'const' on its input
  ! svn_merge_range_contains_rev() - gets 'const' on its input
  ! svn_location_segment_dup() - gets 'const' on its input
  + svn_linenum_t
  + SVN_LINENUM_MAX_VALUE
    # These two 'line number' symbols are in the wrong Doxygen group.
  + SVN_INFO_SIZE_UNKNOWN
    # Says new in 1.5; is it just moved from elsewhere?

svn_version.h
  ! SVN_VER_MINOR - changed to 7
  ! SVN_VER_PATCH - changed to 0
  - svn_version_t - moved from here to svn_types.h

svn_wc.h
  - removed svn_version.h

  + svn_wc_context_t
  + svn_wc_context_create()
  + svn_wc_context_destroy()
  - svn_wc_adm_open3() - deprecated
  - svn_wc_adm_probe_open3() - deprecated
  - svn_wc_adm_open_anchor() - deprecated
  - svn_wc_adm_retrieve() - deprecated
  - svn_wc_adm_probe_retrieve() - deprecated
  - svn_wc_adm_probe_try3() - deprecated
  - svn_wc_adm_close2() - deprecated
  - svn_wc_adm_access_path() - deprecated
  - svn_wc_adm_access_pool() - deprecated
  - svn_wc_adm_locked() - deprecated
  + svn_wc_locked2()
  + SVN_WC_ADM_DIR_NAME
    # Doc'd deprecated; is it just moved?

  + svn_wc_external_update_t
  - svn_wc_traversal_info_t - deprecated
  - svn_wc_init_traversal_info() - deprecated
  - svn_wc_edited_externals() - deprecated
  - svn_wc_traversed_depths() - deprecated

  ! svn_wc_notify_action_t - gets many new values and one deprecated
  ! svn_wc_notify_state_t - gets a new value 'source_missing'
  ! svn_wc_notify_t - gets 'old_revision' and some info for patching

  ! svn_wc_conflict_action_t - gets a new value: 'replace'
  ! svn_wc_conflict_reason_t - gets a new value: 'replaced'
  + svn_wc_conflict_description2_t
    # See '###' comment.
  + svn_wc_conflict_description_create_text2()
  + svn_wc_conflict_description_create_prop2()
  + svn_wc_conflict_description_create_tree2()
  + svn_wc_conflict_resolver_func2_t

  + svn_wc_diff_callbacks4_t - adds 'file_opened' and copyfrom info
    # Should have 'file_closed' too?
    # Deprecation comment doesn't mention 'file_opened'.
    # Copyfrom info should include which repository?

  + svn_wc_check_wc2()

  - svn_wc_has_binary_prop() - deprecated
    # The replacement should be mentioned in the @deprecated clause.

  + svn_wc_text_modified_p2()
  + svn_wc_props_modified_p2()

  = svn_wc_schedule_t - unchanged
    # Should be marked deprecated, as is in a group marked deprecated?
  = SVN_WC_ENTRY_WORKING_SIZE_UNKNOWN - unchanged
    # Should be marked deprecated, as is in a group marked deprecated?
  - svn_wc_entry_t - deprecated
  - svn_wc_entry() - deprecated
  - svn_wc_entries_read() - deprecated
  - svn_wc_entry_dup() - deprecated

  + svn_wc_info_t
    # See '###' comment.
  + svn_wc_info_dup()

  + svn_wc_conflicted_p3()
  - svn_wc_get_ancestry() - deprecated
    # Should say what is the replacement for this functionality.
  - svn_wc_walk_entries3() - deprecated
    # Should say what is the replacement for this functionality.
  - svn_wc_mark_missing_deleted() - deprecated
    # Should say what is the replacement for this functionality.
  + svn_wc_ensure_adm4()
  - svn_wc_ensure_adm3() - deprecated; behaviour change re passing null
    # Doc string should mention 'notes/api-errata/1.7/wc005.txt'.
  - svn_wc_maybe_set_repos_root() - deprecated

  + svn_wc_status3_t
  - svn_wc_status2_t - deprecated; gets 'const' on 'entry' field
    # See '###' comment: 'All diffs are not yet known'.
  ! svn_wc_status_t - gets 'const' on 'entry' field
  + svn_wc_dup_status3()
  + svn_wc_status3()
  + svn_wc_status_func4_t
    # See '###' comment.
  + svn_wc_walk_status()
  + svn_wc_get_status_editor5() - can omit depth filtering
    # '@a statushash' - unknown argument
    # '@a pool' - unknown argument
  ! svn_wc_get_status_editor3() - gets 'const' on an array input

  + svn_wc_copy3()
  + svn_wc_move()
  + svn_wc_delete4()
    # See '###' comment.
  + svn_wc_add_from_disk()
    # See '###' comments.
  + svn_wc_add4()
    # See notes in doc string; remove cases 1 and 2a?
  + svn_wc_add_repos_file4()
  + svn_wc_remove_from_revision_control2()
    # Should be private?
    # Update doc string re. single-db admin areas.
  + svn_wc_resolved_conflict5()

  + svn_wc_queue_committed3()
    # See '###' comments.
  ! svn_wc_queue_committed2() - deprecated; gets 'const' on inputs
  ! svn_wc_queue_committed() - gets 'const' on an array input
  + svn_wc_process_committed_queue2()
  ! svn_wc_process_committed4() - gets 'const' on an array input
  ! svn_wc_process_committed3() - gets 'const' on an array input
  ! svn_wc_process_committed2() - gets 'const' on an array input
  ! svn_wc_process_committed() - gets 'const' on an array input

  + svn_wc_crawl_revisions5() - adds cancellation
  + svn_wc_is_wc_root2()
  + svn_wc_get_wc_root()
  + svn_wc_get_actual_target2()
  + svn_wc_dirents_func_t
    # Doc string: move mention of #3569 to a note; add '@a' before *dirents.
  + svn_wc_get_update_editor4()
  ! svn_wc_get_update_editor3() - deprecated; gets 'const' on an array input
  + svn_wc_get_switch_editor4()
  ! svn_wc_get_switch_editor3() - deprecated; gets 'const' on an array input
  + svn_wc_prop_list2()
  + svn_wc_get_pristine_props()
    # See '###' comment: obsolete comment?
  + svn_wc_prop_get2()
  + svn_wc_prop_set4() - adds depth, changelist, cancellation
  + svn_wc_get_diff_editor6() - adds git format, etc.
  + svn_wc_diff6() - adds git format, etc.
  + svn_wc_get_prop_diffs2()
  + svn_wc_merge4()
  + svn_wc_merge_props3()
  + svn_wc_get_pristine_contents2()
  + svn_wc_cleanup3()
  + svn_wc_upgrade_get_repos_info_t
  + svn_wc_upgrade()
  + svn_wc_relocate4()
  ! svn_wc_relocate3() - behaviour change: must be WC root and recursive
    # Doc should refer to 'notes/api-errata/1.7/...'.
  + svn_wc_revert4()
  + svn_wc_restore()
    # Should have a 'recursive' or 'depth' param? Or is not recursive?
  - svn_wc_create_tmp_file2() - deprecated
    # Should say why/what the replacement is.
  - svn_wc_translated_file2() - deprecated
    # Should say why/what the replacement is.
  - svn_wc_translated_stream() - deprecated
      # Should say why/what the replacement is.
  + svn_wc_transmit_text_deltas3()
  + svn_wc_transmit_prop_deltas2()
  + svn_wc_get_ignores2()
  ! svn_wc_match_ignore_list() - gets 'const' on its array input
  + svn_wc_add_lock2()
  + svn_wc_remove_lock2()
  + svn_wc_revision_status2()
  + svn_wc_set_changelist2()
  + svn_changelist_receiver_t
    # Doc'd as new in 1.5; is it just moved?
  + svn_wc_get_changelists()
  + svn_wc_crop_tree2()
  + svn_wc_exclude()
  + svn_wc_read_kind()
    # See '###' comments re 'hidden'.

- Julian
Received on 2011-06-13 17:22:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.