[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: API review - svn_dirent_uri.h

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Fri, 10 Jun 2011 09:06:07 +0100

I (Julian Foad) wrote:
> On Thu, 2011-06-09, I (Julian Foad) wrote:
> > svn_dirent_uri.h
> > svn_relpath_internal_style()
> > svn_relpath_local_style()
> > # These two are inappropriate: only dirents have a 'local' style.
>
> I removed the former and made the latter private in r1133964.
>
> > svn_dirent_skip_ancestor()
> > # See ### comment.
> > svn_relpath_skip_ancestor()
> > # See ### comment.
> > svn_uri_skip_ancestor()
>
> I intend to make the three skip_ancestor functions return NULL if the
> supposed child is not in fact a child of (or equal to) the parent path.
> No callers appear to want the current behaviour of returning the child
> in that case - I've just confirmed that both by testing and by
> inspection.

Scratch that "confirmation": I've only inspected the relpath one, and my
testing of all of them was flawed.

- Julian
Received on 2011-06-10 10:06:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.