[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: API review - svn_info2_t

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 08 Jun 2011 18:05:41 +0100

Hyrum K Wright wrote:
> Are public consumers intended to read the information from
> svn_wc__info2_t? If so, making it Subversion-private hardly seems
> appropriate....

No, public consumers read svn_client_info2_t which is returned by
svn_client_info3. The private struct is used for communicating from
libsvn_wc to libsvn_client only.

- Julian

> On Wed, Jun 8, 2011 at 10:09 AM, Julian Foad <julian.foad_at_wandisco.com> wrote:
> > Thanks for the additional background, Hyrum.
> >
> > r1133417 moves and renames the struct to become both svn_wc__info2_t and
> > svn_client_info2_t. It's certainly a kind of duplication but it's also
> > the most straightforward solution, I think.
> >
> > I added a 'dup' function for the public one; doing that is what first
> > made me aware of the cyclic dependency and the reason why it should be
> > changed. I haven't yet added a constructor.
> >
> > - Julian
Received on 2011-06-08 19:06:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.