On Wed, Jun 08, 2011 at 09:34:05AM +0300, anatoly techtonik wrote:
> On Mon, Jun 6, 2011 at 6:32 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> > On Thu, Jun 02, 2011 at 07:06:05PM +0300, anatoly techtonik wrote:
> >> Attached patch fixes svnmerge history conversion script to use
> >> optparse library instead of getopt. This allows further addition of
> >> new options, such as --username and --password.
> >
> > Hi,
> >
> > Can you explain why you need to convert this script to optparse
> > to add new options? Is this a cosmetic fix or is there a technical
> > problem with adding more options via getopt? Thanks!
>
> 1. It makes code more clear
> 2. It saves me time on learning what a getopt is
So those who already know getopt should learn about optparse for
your convenience? I don't think that's a good argument.
By the same argument you could send a patch that rewrites the script
in your favourite programming language because you don't like Python.
I don't mind the change in principle because I don't really care
strongly about whether this script should optparse or getopt.
But it is generally better to send minimal patches because they can
be more easily digested and applied. So if all you really want is another
option, I'd be much happier with a patch that just adds this option.
Received on 2011-06-08 11:58:19 CEST