[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1130118 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_subr/subst.c

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Wed, 01 Jun 2011 23:30:48 +0200

On 01.06.2011 16:23, Greg Stein wrote:
> On Jun 1, 2011 10:01 AM, "Stefan Sperling"<stsp_at_elego.de> wrote:
>> On Wed, Jun 01, 2011 at 09:43:35AM -0400, Greg Stein wrote:
>>> On Jun 1, 2011 8:02 AM,<julianfoad_at_apache.org> wrote:
>>>> Author: julianfoad
>>>> Date: Wed Jun 1 12:02:32 2011
>>>> New Revision: 1130118
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1130118&view=rev
>>>> Log:
>>>> Rename svn_stream_buffered() and related symbols to ...is_buffered...
> for
>>>> clarity.
>>> It seems this API is only around to support stream_readline(). Is it
> really
>>> worthwhile to expose this for a single callpoint?
>> I'd say we should move this into private/svn_io_private.h.
> Sounds good to me. Maybe with those other few that Julian just mentioned.
+1 on that. When I introduced this function, I had
no idea that some stream API could be private.
And this is clearly a private interface used by SVN
for internal optimizations.

-- Stefan^2.
Received on 2011-06-01 23:31:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.