[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1130118 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_subr/subst.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 01 Jun 2011 15:45:19 +0100

On Wed, 2011-06-01 at 10:23 -0400, Greg Stein wrote:
> On Jun 1, 2011 10:01 AM, "Stefan Sperling" <stsp_at_elego.de> wrote:
> >
> > On Wed, Jun 01, 2011 at 09:43:35AM -0400, Greg Stein wrote:
> > > On Jun 1, 2011 8:02 AM, <julianfoad_at_apache.org> wrote:
> > > >
> > > > Author: julianfoad
> > > > Date: Wed Jun 1 12:02:32 2011
> > > > New Revision: 1130118
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=1130118&view=rev
> > > > Log:
> > > > Rename svn_stream_buffered() and related symbols to ...is_buffered...
> for
> > > > clarity.
> > >
> > > It seems this API is only around to support stream_readline(). Is it
> really
> > > worthwhile to expose this for a single callpoint?
> >
> > I'd say we should move this into private/svn_io_private.h.
>
> Sounds good to me. Maybe with those other few that Julian just mentioned.

I'll do that. (For anyone skim-reading this: the "other few" that I
mentioned were the other API symbols related to svn_stream_buffered():
svn_io_buffered_fn_t and svn_stream_set_buffered(). I've since renamed
all of those from ...buffered... to ...is_buffered...)

- Julian
Received on 2011-06-01 16:45:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.