Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

On Wed, Jun 1, 2011 at 1:11 AM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Tue, May 31, 2011 at 11:07:55PM -0000, jcorvel_at_apache.org wrote:
>> Author: jcorvel
>> Date: Tue May 31 23:07:54 2011
>> New Revision: 1129957
>>
>> URL: http://svn.apache.org/viewvc?rev=1129957&view=rev
>> Log:
>> Add another knob, to make it possible to disable the prefix/suffix scanning
>> of the libsvn_diff processing with a simple define.
>>
>> * subversion/libsvn_diff/diff_file.c
>>   (datasources_open): Wrap the calls to find_identical_prefix and
>>    find_identical_suffix inside an #ifndef DISABLE_PREFIX_SUFFIX_SCANNING
>>    block.
>> * notes/knobs
>>   (): Document DISABLE_PREFIX_SUFFIX_SCANNING
>
> This should probably be called SVN_DISABLE_PREFIX_SUFFIX_SCANNING.

Hm, I was confused by the following section in notes/knobs:

[[[
The usual namespace rules apply: only names that begin with "SVN_"
and don't contain double underscores are considered part of the public
API. Everything else is not officially supported.
]]]

Thinking: "I don't think this should be part of the public API", so I
can just dispense with the "SVN_" prefix.

-- 
Johan