On 05/20/2011 10:28 PM, Mark Phippard wrote:
> Log message and patch attached.
>
> svnadmin create accepts the --config-dir option but no longer uses it
> for anything. I do not believe we can remove the option from the UI,
> but we can remove the code that get the configuration. The reason is
> that I have observed a couple of odd scenarios where this code causes
> problems.
>
> 1) The process running svnadmin does not have read authority to
> $HOME/.subversion For example, here is an example from a mailing
> list:
>
> http://lists.okfn.org/pipermail/kforge-user/2007-February/000088.html
>
> 2) Have observed similar problem on Windows when the process is
> running and it could not determine the home folder. Never figured out
> the root cause of this problem, as normally this does work OK on
> Windows.
>
> The workaround people have used is to specify --config-dir and point
> it at ' ' or some random folder they can read. But if we just removed
> this code they would not get a problem in the first place.
>
> Ran make check and manually tested the binary.
>
>- SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool));
>- SVN_ERR(svn_cmdline__apply_config_options(config, opt_state->config_options,
>- "svnadmin: ", "--config-option"));
> SVN_ERR(svn_repos_create(&repos, opt_state->repository_path,
> NULL, NULL,
> config, fs_config, pool));
You can as well remove the config parameter and pass NULL instead.
Prabhu posted similar patch 4 months back
http://svn.haxx.se/dev/archive-2011-01/0157.shtml
My +1 for this change.
With regards
Kamesh Jayachandran
Received on 2011-05-21 17:09:46 CEST