[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1125391 - in /subversion/trunk/subversion/libsvn_ra_neon: fetch.c ra_neon.h session.c util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 20 May 2011 10:07:58 -0400

On Fri, May 20, 2011 at 09:48, <ivan_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_ra_neon/fetch.c Fri May 20 13:48:53 2011
>...
> @@ -830,15 +822,8 @@ svn_error_t *svn_ra_neon__get_dir(svn_ra
>          targeted PROPFIND. */
>       if (dirent_fields & SVN_DIRENT_HAS_PROPS)
>         {
> -          const svn_string_t *deadprop_count;
> -
> -          SVN_ERR(svn_ra_neon__get_props_resource(&rsrc, ras, final_url, NULL,
> -                                                  deadprop_count_support_props,
> -                                                  pool));
> -          deadprop_count = apr_hash_get(rsrc->propset,
> -                                        SVN_RA_NEON__PROP_DEADPROP_COUNT,
> -                                        APR_HASH_KEY_STRING);
> -          supports_deadprop_count = (deadprop_count != NULL);
> +          SVN_ERR(svn_ra_neon__get_deadprop_count_support
> +            (&supports_deadprop_count, ras, final_url, pool));

No spaces before func-call parens!

>...
> +++ subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h Fri May 20 13:48:53 2011
> @@ -127,6 +127,12 @@ typedef struct svn_ra_neon__session_t {
>      constants' addresses, therefore). */
>   apr_hash_t *capabilities;
>
> +  /* Tri-state variable holding information about server support for
> +     deadprop-count property. Zero if information still unknown,
> +     positive if server support deadprop-count and negative if it
> +     does not. */
> +  int supports_deadprop_count;

I would suggest svn_tristate_t and its enumerated constants. The bar
0, 1, -1 constants are a big fugly.

>...

Cheers,
-g
Received on 2011-05-20 16:08:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.