[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1125199 - /subversion/trunk/subversion/mod_dav_svn/reports/update.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Fri, 20 May 2011 07:04:07 +0200

> -----Original Message-----
> From: cmpilato_at_apache.org [mailto:cmpilato_at_apache.org]
> Sent: vrijdag 20 mei 2011 3:32
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1125199 -
> /subversion/trunk/subversion/mod_dav_svn/reports/update.c
>
> Author: cmpilato
> Date: Fri May 20 01:31:49 2011
> New Revision: 1125199
>
> URL: http://svn.apache.org/viewvc?rev=1125199&view=rev
> Log:
> Remove a superfluous FS request for the MD5 checksum of every added
> file sent through mod_dav_svn's update editor. As it turns out, the
> editor wasn't doing anything with the value, and the driver of the
> editor (the reporter logic) provides exactly that same checksum via
> the editor's close_file() interface anyway.

Nice one. Just traced it back to r845628 (or r5554) where the checksum argument was added to the close_file(). (The checksum was already fetched before it got that argument)

        Bert
Received on 2011-05-20 07:05:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.