Re: AW: Python bindings: Use of svn_swig_py_make_stream() - avoiding leaking fds

On 10/05/11 16:08, Bert Huijben wrote:

> The python bindings need it, so I would say: Add it there.

The attached patch fixes the FD leak entirely within the Python bindings.

> (And maybe make it easier to use from other bindings when it proves useful. That is why I suggested adding the function in svn_stream.h)

I'm not familiar enough with the use of streams in subversion to be able
to argue for any particular approach; so I hope that by keeping this
entirely to the Python bindings it may be committed.

I expect we'll use this patch (today's version) in our production
service very soon.

 Nick

-- 
Sorry for this disclaimer:
Think green - keep it on the screen.
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.