RE: svn commit: r1099955 - /subversion/trunk/subversion/libsvn_wc/status.c

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: vrijdag 6 mei 2011 0:09
> To: dev_at_subversion.apache.org
> Subject: Re: svn commit: r1099955 -
> /subversion/trunk/subversion/libsvn_wc/status.c
>

> In short: this test is totally obscure. And there are no comments to
explain.
>
> > +
> > +              /* Descend in subdirectories. */
> > +              if (info->kind == svn_wc__db_kind_dir)
>
> Why not just a simple && depth == infinity ?? Why a separate test and
> continue? Way too many if's and branching and weird control flow in
> here.

All the other depth values are handled above this block in this function.
Depth unknown is turned into infinity.

Depth empty doesn't get in the loop at all

Depth files is filtered before this block, for dirs.

And depth immediates is filtered here.

So that leaves depth infinity

The had_props flag was a 'hint' to skip reading the properties. The constant
TRUE values was cheaper then obtaining a real value in those callers. But
for that info instance we already get the real value.

        Bert
Received on 2011-05-06 00:55:04 CEST