Re: svn commit: r1099616 - /subversion/trunk/subversion/svn/commit-cmd.c

On Wed, May 04, 2011 at 09:49:08PM -0000, rhuijben_at_apache.org wrote:
> Author: rhuijben
> Date: Wed May 4 21:49:08 2011
> New Revision: 1099616
>
> URL: http://svn.apache.org/viewvc?rev=1099616&view=rev
> Log:
> Following up on r1099429, revert r1079563 "Warn about committing copied
> directory at depth 'empty'" and r1002094 " In an attempt to prevent
> surprises due to issue #3699"
>
> We don't have to warn for this problem any more, because we can now
> commit the copy without changing its descendants.

Bert, I think you misunderstood what this warning was about.

In my testing, a copied tree is still coped recursively on the server
side with a --depth=empty commit. The warning is there to avoid the
misunderstanding that only the parent node of the copied tree will show
up in the repository with its children pruned from the copy.
However a copy is always made with depth=infinity.

You've fixed a different problem, where *additional* changes made within
the copied tree remain in the working copy. But that's not what the
warning is trying to address.

I think this change should be reverted.
Received on 2011-05-05 14:03:18 CEST